Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch media config from ISAR with API call #1805

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fetch media config from ISAR with API call #1805

merged 2 commits into from
Dec 3, 2024

Conversation

andchiind
Copy link
Contributor

No description provided.

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Nov 22, 2024
@andchiind andchiind self-assigned this Nov 22, 2024
@andchiind andchiind force-pushed the stream-tokens branch 6 times, most recently from 3723223 to 5bc1854 Compare November 28, 2024 14:16
@andchiind andchiind marked this pull request as ready for review November 28, 2024 14:17
@sondreo sondreo self-requested a review November 29, 2024 11:46
sondreo
sondreo reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some minor suggestions.

backend/api/Controllers/MediaStreamController.cs Outdated Show resolved Hide resolved
backend/api/Services/IsarService.cs Outdated Show resolved Hide resolved
@andchiind andchiind force-pushed the stream-tokens branch 3 times, most recently from ad8576a to f78597c Compare December 2, 2024 13:16
sondreo
sondreo approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andchiind andchiind merged commit 4583b47 into equinor:main Dec 3, 2024
11 checks passed
@andchiind andchiind deleted the stream-tokens branch December 3, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreo sondreo sondreo approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andchiind @sondreo